Add unit tests for SelectJdkToolchainMojo version matching - #181
Closed
elharo wants to merge 2 commits into
Closed
Conversation
Fixes apache#174 The static LOCK object and synchronized block around toolchainManagerPrivate.storeToolchainToBuildContext() are unnecessary because: 1. The plugin is marked threadSafe=true, meaning Maven may execute it concurrently for different modules/sessions 2. storeToolchainToBuildContext() stores data into the build context, which is already per-session and thread-safe 3. The static lock introduces unnecessary contention: one module's toolchain selection blocks another unrelated module's selection, defeating the purpose of threadSafe=true In multi-module Maven builds where the toolchains plugin runs in multiple modules, the static lock serializes what could otherwise run in parallel, slowing down builds.
Refs apache#167 Add tests that verify the behavior of the private matches() method in SelectJdkToolchainMojo for the VERSION key, using reflection to avoid changing source code visibility. Tests confirm that RequirementMatcherFactory.createVersionMatcher() is called with the correct argument order: - createVersionMatcher(tcVal).matches(reqVal) where tcVal is the toolchain's concrete version and reqVal is the user's requirement (which may be a range).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #167
Adds unit tests for the
matches()method inSelectJdkToolchainMojoto verify version matching behavior.Uses reflection to test the private method without changing source code visibility. Tests confirm that
RequirementMatcherFactory.createVersionMatcher()is called with the correct argument order:createVersionMatcher(tcVal).matches(reqVal)wheretcValis the toolchain's concrete version andreqValis the user's requirement (which may be a range like"[11,17)").All 3 tests pass against the current code, confirming the existing implementation is correct.